Repository navigation
lab(dr256): persist and reopen the existing OrderIndex (D-DRDT-SPLIT-1 S3) - #2020
Merged
Merged
Conversation
order_store seals the OrderIndex built by OrderIndex::by_i32 into a file (permutation, cached keys, key lane, tie-break key-then-frame-position, mapping and source revisions) and reopens it as the same index. It never sorts: from_bytes only verifies the order. attest refuses another table, a moved mapping, another key or presence version, and a content change with the mapping unchanged (EXO-255: an order index depends on content). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
AdaWorldAPI
marked this pull request as ready for review
November 11, 2026 19:57
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3 of
dr-widefieldmask-dt-classview-v1.md§5.order_storewrites theOrderIndexthatOrderIndex::by_i32builds to a file and reopens it as the same index. It has no sort of its own; on load it only checks the order.What the file holds
KeyLane::Field(u8)orComputed(u64))TIE_KEY_THEN_FRAME_POSITION: ascending key, then the row's position in the bound frameRefusals
attestrefuses the reopened index when any of these changed: the table, the mapping, the key, the presence version, or the source content. The last one holds even when the mapping is unchanged, because an order index depends on content (EXO-255).from_bytesrefuses a bad magic, an unknown layout, an unknown tie-break or key kind, a wrong length, a non-permutation, and keys out of order or ties out of frame-position order.Evidence
cargo test -p dr256-ternlog-lab: all suites pass, 17 of them intests/order_store.rs. clippy-D warningsand fmt are clean.by_i32index: permutation, keys,betweenover five ranges,gt, and theprepare_ordercount.the_module_never_sortsasserts that the source contains no.sort.attestguard short-circuited (T3–T7)from_bytesguard short-circuited (T8–T12)seal(T13, T14, T17).sort()added to the module (T16)Not verified
Generated by Claude Code